Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add versions to Pipfile #971

Closed
1 task
sarayourfriend opened this issue Oct 5, 2022 · 0 comments · Fixed by #989
Closed
1 task

Add versions to Pipfile #971

sarayourfriend opened this issue Oct 5, 2022 · 0 comments · Fixed by #989
Assignees
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents

Comments

@sarayourfriend
Copy link
Contributor

Problem

Right now most of our Pipfile entries use *. This means pipenv will always try to lock to the latest version of a dependency. It also means that if you make any change to the Pipfile pipenv will lock all dependencies to the latest version when it re-locks. This means we cannot do atomic dependency upgrades and causes unrelated changes to introduce potentially breaking version changes in dependencies that are not the focus of a particular change set.

Description

Add versions to Pipfile for the dependencies we already have. Copy the versions currently used from the lock file.

Alternatives

Switch to a different package manager that uses the actual standard pyproject.toml like PDM or Poetry.

Additional context

See this commit to remove locust also upgrading openapi-spec-validator up a minor version causing backwards incompatible changes to be introduced that break out usage of the tool: 7a5aa37

https://github.com/p1c2u/openapi-spec-validator/releases/tag/0.5.0

https://github.com/WordPress/openverse-api/actions/runs/3186730853/jobs/5197684852

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 5, 2022
@krysal krysal added the help wanted Open to participation from the community label Oct 5, 2022
@dhruvkb dhruvkb self-assigned this Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants