Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove unused numeric throttle classses #892

Closed
1 task
zackkrida opened this issue Aug 23, 2022 · 2 comments
Closed
1 task

Remove unused numeric throttle classses #892

zackkrida opened this issue Aug 23, 2022 · 2 comments
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@zackkrida
Copy link
Member

Problem

As discussed in the comments of #864, we should remove the unused throttle classes OneThousandPerMinute and OnePerSecond.

Description

Removing unused code.

Alternatives

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@zackkrida zackkrida added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Aug 23, 2022
@AetherUnbound
Copy link
Contributor

Unfortunately, these classes are all presently being used:

TenPerDay

throttle_classes = (TenPerDay,)

OneThousandPerMinute

throttle_classes=[OneThousandPerMinute],

throttle_classes=[OneThousandPerMinute],

OnePerSecond

throttle_classes = (OnePerSecond,)


Perhaps they could be replaced with other throttle classes we have now, I'm not familiar enough with the throttling setup to be able to tell at this point.

@krysal
Copy link
Member

krysal commented Oct 3, 2022

Excellent find @AetherUnbound! I'll close the issue as we can always open another one if a clear need arises.

@krysal krysal closed this as completed Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

No branches or pull requests

3 participants