Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Replace PYTHON_ENV with ENVIRONMENT #475

Closed
1 task done
sarayourfriend opened this issue Jan 20, 2022 · 0 comments · Fixed by #476
Closed
1 task done

Replace PYTHON_ENV with ENVIRONMENT #475

sarayourfriend opened this issue Jan 20, 2022 · 0 comments · Fixed by #476
Assignees
@sarayourfriend
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@sarayourfriend
Copy link
Contributor

Description

Our deployment infrastructure already configures an ENVIRONMENT variable and it is already used in the ingestion server code. Rather than introduce a new one that duplicates that, we can just use that everywhere.

Making this change will solve the issue we're seeing Sentry where staging is reporting itself as production.

Resolution

  • 🙋 I would be interested in resolving this bug.
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jan 20, 2022
@sarayourfriend sarayourfriend self-assigned this Jan 20, 2022
@sarayourfriend sarayourfriend mentioned this issue Jan 20, 2022
Merged
5 tasks
This was referenced Jan 21, 2022
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarayourfriend sarayourfriend

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the existing and configured env indicator WordPress/openverse-api
1 participant
@sarayourfriend