Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Use get_redis_connection rather than django.core.cache for thumbnail timeouts #1073

Closed
AetherUnbound opened this issue Jan 4, 2023 · 1 comment
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🐍 tech: python Requires familiarity with Python

Comments

@AetherUnbound
Copy link
Contributor

Description

Capturing which domains had thumbnail timeouts on the API was added in #982. However, @sarayourfriend found that using django.core.cache implicitly uses the default Django cache timeout. For our setup this is currently 5 minutes, which means that the thumbnail timeout entries only exist in Redis for 5 minutes.

We would like to switch the thumbnail timeout capturing from using the default django.core.cache to use get_redis_connection instead, so that no default timeout is applied when the associated values are added or updated.

Additional context

This is a stop-gap change, and is intended to be supplanted by #1072

@AetherUnbound AetherUnbound added good first issue New-contributor friendly help wanted Open to participation from the community 🐍 tech: python Requires familiarity with Python 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Jan 4, 2023
@sarayourfriend sarayourfriend self-assigned this Jan 9, 2023
@sarayourfriend
Copy link
Contributor

sarayourfriend commented Jan 9, 2023

This was incidentally resolved by #1056.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents 🐍 tech: python Requires familiarity with Python
Projects
None yet
Development

No branches or pull requests

2 participants