New performance page #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal for a new perfromance page.
sybrew
reviewed
Jul 1, 2020
getsource
reviewed
Jul 13, 2020
| @@ -100,7 +100,7 @@ In case you work with systems like nginx or LiteSpeed you have these: [LiteSpeed | |||
|
|
|||
| Every time a request comes to your web server, PHP has to execute and calculate everything, but PHP allows an internal operation caching system, which means that a copy of each execution is stored in memory or on disk. If it is active and the same operation is executed again, the system will take advantage of this system to return the calculation much faster, since it does not have to calculate everything completely. | |||
|
|
|||
| If your hosting provider has it active and configured, you can make use of it, but always taking into account that you will need a plugin to make the invalidation of the contents when necessary. | |||
| If your hosting provider has it active and configured, you can make use of it, but always taking into account that you may need a plugin to make the invalidation of the contents when necessary, considering `opcache.validate_timestamps` may or may not be configured. | |||
There was a problem hiding this comment.
This isn't a review for the whole new page, but since this is documentation for hosting providers, I'd prefer to see this written in a way that recommends the best way for hosts to configure OPcache, rather than a way for users to work around how the host has it configured.
getsource
reviewed
Jul 13, 2020
| There are many ways to make the calls corresponding to the scheduled tasks, so it is highly recommended that you talk to your web hosting provider for recommendations. |
There was a problem hiding this comment.
The same here -- let's recommend or give options for what is recommended, rather than suggesting a host contact their host.
|
Requires a lot of improvement... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for a new perfromance page.