Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bottom box shadow to the scroll inserter, indicating you can scroll. This fixes #776.
Originally I also intended to look deeper into whether we could fix scroll bleed. I got far enough that if we add this CSS, we can prevent scrolling of the body content:
That worked pretty well — all you had to do with that is add the CSS class
is-scroll-locked
when mousing over something like the inserter, then remove it again when mousing off. Then scroll bleed solved.Problem is, it relies on creating a fake scrollbar to indent the page, so there isn't a jarring page "jog" when the scrollbar is locked away. This doesn't work with fixed position elements, beckoning hacks that I don't think we'll want to go into.
As such, it seems if we want to address scroll bleed, we should probably look into https://codepen.io/joen/pen/dMEyjr or https://codepen.io/joen/pen/wGLjWG.
In the mean time, no reason not to merge this in, right?