Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11: Fix default appender placeholder #8837

Merged
merged 1 commit into from
Aug 13, 2018
Merged

IE11: Fix default appender placeholder #8837

merged 1 commit into from
Aug 13, 2018

Conversation

youknowriad
Copy link
Contributor

closes #8654

It looks like the line-height for inputs in IE11 is causing issues like this: The placeholder getting clipped on the bottom.

Testing instructions

  • Make sure the "Write Store" placeholder shows up properly in different browsers.

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended Browser Issues Issues or PRs that are related to browser specific problems labels Aug 10, 2018
@youknowriad youknowriad self-assigned this Aug 10, 2018
kjellr
kjellr approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in:
Windows 7: IE 11.0.9600.19080
Mac OS 10.13.6: Safari 11.1.2, Firefox 61.0.2
iOS 11.4: Safari

Worked great in each case. 👍

@youknowriad youknowriad merged commit 216f279 into master Aug 13, 2018
@youknowriad youknowriad deleted the fix/default-appender-ie11 branch August 13, 2018 08:36
@mtias mtias added this to the 3.6 milestone Aug 16, 2018
@Aljullu Aljullu mentioned this pull request Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellr kjellr kjellr approved these changes

@jasmussen jasmussen Awaiting requested review from jasmussen

Assignees

@youknowriad youknowriad

Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

IE11: "Write your story" placeholder is clipped on the bottom.
3 participants
@youknowriad @kjellr @mtias