Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page List Block: Refactor settings panel to use ToolsPanel #67903

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Dec 13, 2024

Part of: #67813
Fixes: #67932

What?

Refactored Page List Block code to include ToolsPanel instead of PanelBody.

Screenshots or screencast

Trunk In this PR
image image image

@im3dabasia im3dabasia marked this pull request as ready for review December 13, 2024 10:15
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@fabiankaegy fabiankaegy added [Block] Page List Affects the Page List Block [Type] Enhancement A suggestion for improvement. labels Dec 13, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected :) 🚀

CleanShot.2024-12-13.at.23.47.16.mp4

@fabiankaegy fabiankaegy merged commit e9fb12f into WordPress:trunk Dec 13, 2024
69 of 72 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Page List Affects the Page List Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Page List block to use ToolsPanel instead of PanelBody
2 participants