wp-env: Add multi-site alternative. #67852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
mcsf
reviewed
Dec 12, 2024
| @@ -80,6 +119,14 @@ module.exports = async function initConfig( { | |||
| yaml.dump( dockerComposeConfig ) | |||
| ); | |||
|
|
|||
| // Add multisite .htaccess if multisite is enabled | |||
| if ( config.env.multisite ) { | |||
| await writeMultisiteHtaccess( '/var/www/html' ); | |||
There was a problem hiding this comment.
This is a drive-by remark (I'm on my phone and I'll have a better look in the morning), but isn't this saving to the host's own filesystem? Isn't there a path.join missing, or a docker-compose mount missing?
There was a problem hiding this comment.
The path join is added in line 48. It is creating the file on the Dockerfile.
|
Closing the PR as duplicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #67845
Why?
Learning, I discovered the other PR just after this one was "working". #67845 is more complete, but I'll leave this one closed just for learning purposes and to not "trash" a day of work 😆