Clean script: Use braces instead of @-pattern for glob #67833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
t-hamano
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Thanks for the fix! I should have thoroughly tested all scripts 😥
I noticed that the fixtures:clean command wasn't working properly either on Windows:
npm run fixtures:clean
> [email protected] fixtures:clean
> rimraf --glob 'test/integration/fixtures/blocks/*.+(json|serialized.html)'
'serialized.html)'' is not recognized as an internal or external command,
operable program or batch file.
I think this command isn't used in core so maybe we can address it in a follow-up, but will we fix it in this PR?
t-hamano
added
the
OS Issues
|
If the clean packages script is working then we can apply the same change to the fixtures clean script I think. I'll add that change. |
t-hamano
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
The error no longer occurs, but it seems that the files are not deleted on Windows OS:
d950ab3cc15f78ffa2d3a0aaad139078.mp4
However, it works correctly on Linux. Therefore, if this PR is urgent, it may be better to merge this PR once and address the issue in a follow-up.
Therefore, I will approve this PR.
|
Thanks @t-hamano 😕 I will land this so that CI is not broken on the Core repo and we can address those problems in a follow-up. Maybe just using simpler patterns will work for fixtures: diff --git before/package.json after/package.json
index a0182e2e27..846fae9550 100644
--- before/package.json
+++ after/package.json
@@ -193,7 +193,7 @@
"docs:gen": "node ./docs/tool/index.js",
"docs:theme-ref": "node ./bin/api-docs/gen-theme-reference.mjs",
"env": "wp-env",
- "fixtures:clean": "rimraf --glob 'test/integration/fixtures/blocks/*.{json,serialized.html}'",
+ "fixtures:clean": "rimraf --glob 'test/integration/fixtures/blocks/*.json' 'test/integration/fixtures/blocks/*.serialized.html'",
"fixtures:generate": "cross-env GENERATE_MISSING_FIXTURES=y npm run test:unit test/integration/full-content/ && npm run format test/integration/fixtures/blocks/*.json",
"fixtures:regenerate": "npm-run-all fixtures:clean fixtures:generate",
"format": "wp-scripts format",(this works on macOS) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Try braces instead of @-pattern to fix a windows build issue:
I don't have a good setup to debug this, I have no good way of reproducing the issue or verifying the fix.
Follow-up to #67829.
Why?
Trying to get those windows build issues addressed.
How?
Try a different glob pattern to expand to the desired paths.
Testing Instructions
prints
prints