Add --glob argument to rimraf cli scripts #67829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimraf now requires the --glob option https://github.com/isaacs/rimraf?tab=readme-ov-file#v3-to-v4
It seems likely that shell expansion was handling these globs on some systems but not on windows. Use single quotes to avoid shell glob behavior and rely on rimraf
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
t-hamano
approved these changes
Dec 11, 2024
|
Thank you for the follow-up. That's the risk of bumping dependencies to fix reported vulnerabilities ... |
|
There was progress, but this still didn't fix the windows issue 😩 I'm not sure what the problem is with that… maybe we can use braces instead of the @t-hamano are you able to reproduce the issue? |
|
#67833 tries this with braces. |
t-hamano
added
the
OS Issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
rimraf now requires the --glob option, add it.
Use single quotes to avoid shell glob handling. It seems likely that some shells were handling the glob, but previously the glob was handled by rimraf. Single quotes should ensure that the glob is handled by rimraf everywhere.
https://github.com/isaacs/rimraf?tab=readme-ov-file#v3-to-v4
Follow-up to #67708
Windows builds started to fail, for example:
Why?
This should work, the
--globoption is now required.Testing Instructions
prints
prints