[Dataviews] Fix: Media item focus style is not visible on Grid. #67789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +122 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Dec 10, 2024
| } | ||
| &.is-selected .dataviews-view-grid__media::after, |
There was a problem hiding this comment.
It works for me, but I welcome feedback from design: in the grid view, do we need to distinguish from a "selected" state and from a "focused" state? (I presume this would be fine to tweak as a follow-up if necessary)
| Selected | Focused |
|---|---|
 |
 |
cc @jameskoster
There was a problem hiding this comment.
Thanks for the ping. The focus treatment should utilise the var(--wp-admin-border-width-focus) (1.5px) stroke width. The stroke for the selected item should be only 1px.
oandregal
approved these changes
Dec 10, 2024
jorgefilipecosta
force-pushed
the
fix/grid-media-item-focus-style-is-not-visible
branch
from
6bd5abf to
e381324
Compare
jorgefilipecosta
force-pushed
the
fix/grid-media-item-focus-style-is-not-visible
branch
from
e381324 to
9bb35cf
Compare
jorgefilipecosta
deleted the
fix/grid-media-item-focus-style-is-not-visible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue noticed by @oandregal at #67690 (comment).
Currently, the grid item media button does not communicate that the item is focused. This PR solves the issue by applying a blue border to the focused item.
Screenshots
Testing Instructions
Go to
wp-admin/site-editor.php?p=%2Fpage&layout=grid.Focus the search field tab until you focus a grid item and verify it has a focus style.