DataViews: Fix text in action for setting site home page #67787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
commented
Dec 10, 2024
|
|
||
| const modalText = sprintf( | ||
| // translators: %1$s: title of the page to be set as the homepage, %2$s: homepage replacement warning message. | ||
| __( 'Set "%1$s" as the site homepage? %2$s' ), | ||
| pageTitle, | ||
| modalWarning | ||
| ); | ||
| ).trim(); |
There was a problem hiding this comment.
This prevents a space from being left at the end of the modalText variable if modalWarning is an empty string.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +33 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
mikachan
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Thanks @t-hamano!
This fixes an issue I was seeing in #65426 that I was struggling to replicate consistently.
In my testing this works as advertised 👍
- Homepage: empty / Posts page: empty ✅
- Homepage: The page is set / Posts page: empty ✅
- Homepage: empty / Posts page: The page is set ✅
- Homepage: The page is set / Posts page: The page is set ✅
|
@mikachan Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #65426
What?
Fixes odd text that appears when setting the home page via the DataViews in the following settings:
When only the "Posts page" is set, it shows that it will replace the homepage even though no homepage has been set yet. Additionally, the page title is empty:
Testing Instructions
Screenshots or screencast
The correct text should now be displayed in all scenarios.
Homepage: empty / Posts page: empty
Homepage: The page is set / Posts page: empty
Homepage: empty / Posts page: The page is set
Homepage: The page is set / Posts page: The page is set