Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated 'Set featured image' text in dropdown #67775

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Updated 'Set featured image' text in dropdown #67775

merged 1 commit into from
Dec 10, 2024

Conversation

benazeer-ben
Copy link
Contributor

What?

Fix mentioned in #67761

Why?

As per the ticket, current text can be misinterpreted that you will be guided to an interface to select a featured image which has already available in side panel.

How?

Update the text in the dropdown menu to 'Set as featured image',

Testing Instructions

  • Go to WP page/post edit screen.
  • Add a new image block.
  • Upload a new image
  • Open the options dropdown menu.
  • Now the text updated to 'Set as featured image'.

Screenshots or screencast

Before:
featuredbefore
After:
featuredafter

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: benazeer-ben <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: timse201 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@talldan talldan linked an issue Dec 10, 2024 that may be closed by this pull request
"set featured image" can be misinterpreted #67761
Closed
6 tasks
@Mamaduka Mamaduka mentioned this pull request Dec 10, 2024
Closed
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Dec 10, 2024
Mamaduka
Mamaduka approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @benazeer-ben!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Dec 10, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Dec 10, 2024
@Mamaduka Mamaduka merged commit 20a9a81 into WordPress:trunk Dec 10, 2024
70 of 73 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@artemiomorales artemiomorales Awaiting requested review from artemiomorales artemiomorales is a code owner

Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 19.9
Development

Successfully merging this pull request may close these issues.

"set featured image" can be misinterpreted
2 participants
@benazeer-ben @Mamaduka