Renders DataForm component only when data has been fetched
#67694
+21
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
[Feature] DataViews
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +15 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b8c5361. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12200871013
|
youknowriad
reviewed
Dec 6, 2024
|
Thanks for the review! I don't have a strong preference, but for gutenberg/packages/dataviews/README.md Lines 334 to 336 in b8c5361 Mostly, I added it for “consistency”.
I'm okay with this approach, too. |
|
I don't think we manage very well the loading states in DataViews. Said that, the |
|
Yes, in DataViews, the component is not just about the "table" or the "grid", it's also about the filters... I do think the current isLoading in dataviews is not great, it should probably just be at the top level to be honest outside the component but better loading indicators... is probably needed later especially when switching config... |
gigitux
changed the title
DataForm component only when data has been fetched
…aform-improve-loading-state-management
|
Thanks for your precious feedback (as always). I updated the PR! |
oandregal
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR renders
DataFormcomponent only when data has been fetched.Why?
We experienced runtime crashes when certain fields expected defined data but received a boolean value (
false). This occurred becausegetEditedEntityRecordwas still fetching data and returnedfalseas a fallback.Instead, according to type definition, fields expect to receive the
Item:https://github.com/WordPress/gutenberg/blob/e4df49ffc87d7f2076d4ea7e0e8bc6698bcc60ff/packages/dataviews/src/types.ts#L549-L555
To avoid runtime crashes,
DataFormcomponent needs to run only when data has been fetched.How?
Testing Instructions
console.log(data)on this lineScreen.Capture.on.2024-12-06.at.15-45-37.mov
Screen.Capture.on.2024-12-06.at.15-45-37.mov