Block Editor: Remove 'React.Children' legacy API in 'Warning' component #67675
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Dec 6, 2024
Mamaduka
commented
Dec 6, 2024
| @@ -18,7 +18,9 @@ describe( 'Warning', () => { | |||
|
|
|||
| it( 'should show primary actions', () => { | |||
| render( | |||
| <Warning actions={ <button>Click me</button> }>Message</Warning> | |||
There was a problem hiding this comment.
I'm not sure why we allowed this behavior. The prop is used and documented as an array.
youknowriad
reviewed
Dec 6, 2024
| @@ -18,7 +18,9 @@ describe( 'Warning', () => { | |||
|
|
|||
| it( 'should show primary actions', () => { | |||
| render( | |||
| <Warning actions={ <button>Click me</button> }>Message</Warning> | |||
| <Warning actions={ [ <button key="test">Click me</button> ] }> | |||
There was a problem hiding this comment.
This is an interesting case. Maybe we should account for the case where it's not an array.
There was a problem hiding this comment.
I checked, and consumers have always treated actions as array props since the introduction - #5483.
There was a problem hiding this comment.
I don't feel strongly :)
|
Size Change: -11 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
I'll merge this and follow up if any bugs are reported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes
React.Childrenusage from theWarningcomponent and replaces it with normal array operations.Why?
actionsprop is just an array of action components. It doesn't need a special handling.React.Childrenis now a legacy API, and official documentation discourages its use.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast