Site Editor: remove default page slug #67673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Dec 6, 2024
|
Size Change: +2 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Dec 6, 2024
|
Thanks for testing, folks!! The E2E fails are real but I can also see the tests failing on trunk locally. The issue seems to be that after creating a page and adding some groups and paragraphs, the post-content block and all its children are disabled. They have a class of It does not occur in manual testing under the same test conditions 🤔 I'll leave this PR to simmer until I can work out what's happening on Monday. |
…so look for a corresponding page- template that matches the slug name. Therefore if a page template exists with the name page-no-title, WordPress will apply that template to any page with that unique slug. This causes unexpected template assigment. TT4 and TT5 most notably. It's also inconsistent since subsequent untitled pages created in the site editor will use the default template, slugs being unique. Anyway, let's just use WordPress's default behavior, which is to create a unique slug using wp_unique_post_slug if none exists.
ramonjd
force-pushed
the
remove/default-page-slug-site-editor
branch
from
1b52e95 to
d16b603
Compare
Untrue. I was tripping.
True, on this branch. I don't know why it only affected specific tests, but I tracked it down to the absence of a I don't know yet why. I've checked core data actions and reducers, and places where the slug is fetched. Anyway, I've kept the slug key, but removed 'No title' and replaced with The effect is the same and the tests pass. I checked:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #67539
Removes the default slug assignment when creating an untitled page in the site editor.
Why?
WordPress will try to create a slug from the title. WordPress will also look for a corresponding
page-template that matches the slug name.Therefore if a page template exists with the name page-no-title, WordPress will apply that template to any page with that unique slug.
This causes unexpected template assignment. TT4 and TT5 most notably, both of which have
page-no-titletemplates!It's also inconsistent since subsequent untitled pages created in the site editor will use the default template, slugs being unique.
How?
Anyway, let's just use WordPress's default behavior, which is to create a unique slug using wp_unique_post_slug if none exists.
This is what happens in the post editor. Why should the site editor get special treatment?
It shouldn't! That's why.
I have spoken.
Testing Instructions
Head to the Site Editor and create page.
Don't give it a title!!
Once created, check out the slug in the page settings in the right hand side panel. It should be something like
"$page_id-$suffix", e.g.,12-2That's it!