-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Fix control types #67646
Storybook: Fix control types #67646
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
@@ -16,13 +16,13 @@ const meta = { | |||
component: AlignmentToolbar, | |||
argTypes: { | |||
value: { | |||
control: { type: false }, | |||
control: { type: undefined }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we misread the docs 😂 Does this pass?
control: { type: undefined }, | |
control: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, looks like it does. Updated in e2b13c0
false
control types to undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙈
Thanks Lena 🙇 |
Flaky tests detected in e2b13c0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12183762273
|
What?
This fixes control types so they work both in Storybook 7 and 8.
Part of #67574
Why?
Preparatory work for upgrading Storybook v8 -
false
controls cause type errors with v8.How?
Just updating the types.
Testing Instructions
Verify Storybook builds well and test a few controls to ensure they work the same way.
Testing Instructions for Keyboard
Same
Screenshots or screencast
None