Hide separators for currently dragged section in Zoom Out #67638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +63 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
richtabor
approved these changes
Dec 6, 2024
@richtabor I think @ellatrix is working on something like that in #67470. |
getdave
force-pushed
the
try/zoom-out-hide-separators-for-current-dragged-block
branch
from
a4c9795 to
b8b76b7
Compare
mikachan
approved these changes
Dec 6, 2024
|
Flaky tests detected in b8b76b7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12198503164
|
getdave
force-pushed
the
try/zoom-out-hide-separators-for-current-dragged-block
branch
2 times, most recently
from
1f4d5b4 to
ec0a90b
Compare
getdave
force-pushed
the
try/zoom-out-hide-separators-for-current-dragged-block
branch
from
ec0a90b to
f38e063
Compare
getdave
deleted the
try/zoom-out-hide-separators-for-current-dragged-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hide the drag and drop separators for currently dragged section in Zoom Out.
Closes #67567
Why?
See #67567
How?
Hides the Zoom Out Separator if
The sibling requirement is a product of the fact that dropzones appear below each section and the previous block's dropzone can be activated by moving near the top of the current block when dragging.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-12-05.at.14-50-15.mp4