Remove __unstableMotionContext from @wordpress/components
#67623
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Base automatically changed from
cleanup/remove-framer-motion-context-forwarding
to
trunk
December 5, 2024 12:00
ciampo
force-pushed
the
remove/framer-motion-context
branch
from
f4da040 to
126a908
Compare
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Remove unused `__unstableMotionContext` export from `@wordpress/components` * CHANGELOG --- Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Requires #67522 to be merged first
Remove the
__unstableMotionContextexport from the@wordpress/componentspackage.Why?
As discussed in #67522 (comment), the export is not needed anymore in Gutenberg, and there are no usages in plugins: Looks like there's no usage in plugins: https://wpdirectory.net/search/01JE66GHXATVJHR1K7PQQG074W.
This also reduces the number of
__unstable*APIs.How?
Delete the export.
Testing Instructions
Make sure the project builds correctly and that there are no usages left across Gutenberg and third party plugins.