Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove unused test code on tools panel. #67589

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

jorgefilipecosta
Copy link
Member

The code after "false &&" is not used at all and can be removed. It is also not required for the test to make sense either.

@jorgefilipecosta jorgefilipecosta added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Dec 4, 2024

Flaky tests detected in 87f7ce7.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12164476341
📝 Reported issues:

@jorgefilipecosta jorgefilipecosta merged commit 0b3a191 into trunk Dec 5, 2024
66 of 68 checks passed
@jorgefilipecosta jorgefilipecosta deleted the fix/remove-unused-test-code-on-tools-panel branch December 5, 2024 09:48
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 5, 2024
michalczaplinski pushed a commit that referenced this pull request Dec 5, 2024
Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants