Fix: Fixed site-editor crashing when added front-page template and clicking more option

[Mayank-Tripathi32]

resolves #67498

What?

This PR modifies how the array for actions is constructed by using default action destructuring and conditionally pushing values to the array.

Why?

The previous implementation was adding an empty array at the end of the actions list when the condition for shouldShowSetAsHomepageAction was false. This caused issues, particularly in the "More Options" menu, where an empty action was being passed and leading to a crash. This PR resolves that by ensuring that only valid actions are added to the array.

How?

To address this issue, I changed the following snippet:
Old Code:

let actions = [
    ...defaultActions,
    shouldShowSetAsHomepageAction ? setAsHomepageAction : [],
];

The previous code resulted in adding an empty array at the end when the condition shouldShowSetAsHomepageAction was false.

New Code:

let actions = [...defaultActions];
if (shouldShowSetAsHomepageAction) {
    actions.push(setAsHomepageAction);
}

This change ensures that if shouldShowSetAsHomepageAction is false, the setAsHomepageAction is not pushed into the array, avoiding the empty array scenario and preventing the crash.

Testing Instructions

1. Go to Appearance > Editor (Site Editor) in the WordPress admin > Templates.
2. Add a new Front Page template through the Site Editor.
3. Save the changes to ensure the template is added.
4. Click on the three dots (More Options) for any template in the template list.
5. It should not crashe the page anymore
6. Now delete front page template and click, it should work as expected.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mayank-Tripathi32 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[t-hamano]

Thanks for the PR!

Perhaps the original code should have been written like this:

const actions = [
  ...defaultActions,
  ...(shouldShowSetAsHomepageAction ? [setAsHomepageAction] : []),
];

However, I think it would be clearer to use the push method, as done in this PR. Let's get some feedback from the contributors who worked on #65426.

[oandregal]

Thank you!

[mikachan]

Thanks for fixing this!