Preload: fix e2e test #67497
Merged
Preload: fix e2e test #67497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Going to merge this because it's just fixing a test and adding a simple preload path. |
Mamaduka
reviewed
Dec 3, 2024
Comment on lines
+46
to
+48
| // There are two separate settings OPTIONS requests. We should fix | ||
| // so the one for canUser and getEntityRecord are reused. | ||
| '/wp/v2/settings', |
There was a problem hiding this comment.
Maybe we should delay the destruction of the preloaded cache by a couple of MS instead of removing it after the first match. Technically, this should help resolve anything in the critical path via cache without "affecting" the PreloadingMiddleware behavior.
gutenberg/packages/api-fetch/src/middlewares/preloading.js
Lines 53 to 54 in 5c76815
There was a problem hiding this comment.
Maybe next idle callback? Still, it doesn't feel like clean solution but it could work for now I guess.
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
|
This e2e test keeps failing for me on #67591 and I'm not sure why. It's consistently happening for me though. Any idea why? |
|
Adding I could get the preload test to fail locally by adding this test block to the top of Adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I added an e2e test in #67475, but it doesn't seem to work correctly since it's missing some requests.
Why?
It should catch all the requests.
How?
We start recording before page load, then turn off recording when the iframe src is requested.
Testing Instructions
Nothing, you can see that the remaining URLs are now properly recorded. I've also added one more to the preload list that was showing up.
Testing Instructions for Keyboard