-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useEditorTitle: fix wrong request without ID #67475
Merged
+45
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' ); | ||
|
||
test.describe( 'Preload', () => { | ||
test.beforeAll( async ( { requestUtils } ) => { | ||
await requestUtils.activateTheme( 'emptytheme' ); | ||
} ); | ||
|
||
test.afterAll( async ( { requestUtils } ) => { | ||
await requestUtils.activateTheme( 'twentytwentyone' ); | ||
} ); | ||
|
||
test( 'Should make no requests before the iframe is loaded', async ( { | ||
page, | ||
admin, | ||
} ) => { | ||
// Do not use `visitSiteEditor` because it waits for the iframe to load. | ||
await admin.visitAdminPage( 'site-editor.php' ); | ||
|
||
const requests = []; | ||
let isLoaded = false; | ||
|
||
page.on( 'request', ( request ) => { | ||
if ( request.resourceType() === 'document' ) { | ||
// The iframe also "requests" a blob document. This is the most | ||
// reliable way to wait for the iframe to start loading. | ||
// `waitForSelector` is always a bit delayed, and we don't want | ||
// to detect requests after the iframe mounts. | ||
isLoaded = true; | ||
} else if ( ! isLoaded && request.resourceType() === 'fetch' ) { | ||
requests.push( request.url() ); | ||
} | ||
} ); | ||
|
||
await page.waitForFunction( ( _isLoaded ) => _isLoaded, [ isLoaded ] ); | ||
|
||
expect( requests ).toEqual( [] ); | ||
} ); | ||
} ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the home page of the site editor, there's no postId (and other pages). Won't this have an impact there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the site editor root? Yes, there's an ID it seems, it's the template ID. Which other pages would have no ID?
useEditorTitle
seems to always be called either the post/page ID or the template ID.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think when you are on data view pages, the title does not update, but that's the case in trunk too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, it's currently not erroring because
getEditedEntityRecord
returnsfalse
if it's not loaded yet, whichgetTemplateInfo
is destructuring.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right.