-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload: parse post ID from p (path) #67465
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@@ -10,8 +10,16 @@ | |||
*/ | |||
function gutenberg_block_editor_preload_paths_6_8( $paths, $context ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ideally, we should build some kind of "router" that has equivalent paths to the router we use in the site editor. But this address the important use-case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also would be cool to kind of allow using packages from packagist. Matching routes is a solved problem already in PHP in different packages.
Flaky tests detected in fd482b9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12117697666
|
Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]>
Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]>
What?
Since #67199, post preload no longer works for this path:
Why?
Preloading improves load performance when accessing site editor URLs directly.
How?
Parse the ID from the new path.
Testing Instructions
Load a page with the above URL and check the (first few) network requests.
Testing Instructions for Keyboard
Screenshots or screencast