Simplify description and option names in the Lock modal dialog

[sarthaknagoshe2002]

Fixes: #62843

What?

This PR simplifies the description and renames the options in the Lock modal dialog to make the interface clearer and more intuitive for users.

Why?

The original description was too long and confusing, with mismatched visuals and terminology that added cognitive load. Additionally, the varying verbs for options were inconsistent and unnecessary. Simplifying the language and standardizing the option names enhances user understanding.

How?

1. The description was updated to focus on user intent: "Choose 'Lock all' to disable all actions, or select specific features to lock."
2. Option names were standardized to:
   • Lock all
   • Lock editing
   • Lock movement
   • Lock removal

Testing Instructions

1. Add a Navigation block to a post.
2. Select the Navigation block and click Options > Lock.
3. Observe the updated description and option names. Ensure the visual order aligns with the description.
4. Verify the interface is now clearer and easier to understand.

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sarthaknagoshe2002 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: afercia <[email protected]>
Co-authored-by: mtias <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[t-hamano]

Thanks for the PR!

In order to resolve the E2E test failure, could you also update the strings Disable movement and Prevent removal contained in the following files?

• test/e2e/specs/editor/blocks/columns.spec.js
• test/e2e/specs/editor/various/block-locking.spec.js
• test/e2e/specs/editor/various/block-switcher.spec.js

[afercia]

Thanks for the PR! One of the points from the issue #62843 is that this text is now the legend of a fieldset element. It's too long to be a legend, it would be nice to make it way shorter.

What about something along the lines of Choose the features to lock?

[sarthaknagoshe2002]

Choose the features to lock. sounds good too.
Alternatively it can also be Select the features you want to lock.

[sarthaknagoshe2002]

@t-hamano I wanted to know whether I should also change the test title string?

[t-hamano]

I wanted to know whether I should also change the test title string?

Thanks for the PR! I think the title of the test is fine as is.

[sarthaknagoshe2002]

Okay the I guess we are good to merge.
Just need to re-run the playwright test

[t-hamano]

Personally, I think all the text is correct and we can merge this PR.

@afercia Any additional feedback would be appreciated.

[afercia]

Only point left is adjusting the legend text

[afercia]

To me, the only thing left is to improve the legend text. The current one:

Choose "Lock all" to disable all actions, or select specific features to lock

• is a too long: please consider that some screen readers may repeat a fieldset legend when focusing each form control inside a fieldset.
• The UI is already self-explanatory: there is already a 'Lock all' checkbox with sub-options. As such, the current text of the legend seems unnecessary.
• More importantly, a fieldset legend is meant to give a name to the grouping of the fieldset. It's not a place for instructions. It should clarify what the form controls within the fieldset are about.

'Choose the features to lock' or 'Choose the features to lock' would be more appropriate.

[sarthaknagoshe2002]

@afercia & @t-hamano referring to this comment

Between the two, "Select the features you want to lock" sounds better.

"Select the features you want to lock" sounds better because it’s clearer and more user-friendly.

It feels more personal by saying "you want to lock," which puts the focus on the user’s choice. It also uses the word "select," which is a common term in apps or websites, so it feels natural if someone is clicking or choosing something on a screen.

On the other hand, "Choose the features to lock" is shorter but a bit vague. It doesn’t feel as specific or connected to the user.

[afercia]

"Select the features you want to lock" sounds good to me.

[t-hamano]

@sarthaknagoshe2002 Thanks for the update! Based on the discussion so far, this PR looks ready to ship 👍

This PR has been updated based on the feedback