Remove one occurrence of incorrect usage of ItemGroup. #67427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bcbf51e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12116201721
|
|
The change makes sense, but now the Before
After
|
|
That makes perfect sense @afercia. Let’s make sure the text is only displayed when any attribute is connected to the binding source. We should check whether |
|
It makes sense to me as well 🙂 It is already destructuring |
gziolo
reviewed
Dec 2, 2024
Comment on lines
303
to
307
| <Text as="p" variant="muted"> | ||
| { __( | ||
| 'Attributes connected to custom fields or other dynamic data.' | ||
| ) } | ||
| </Text> |
There was a problem hiding this comment.
The fix outlined by @SantosGuillamot in #67427 (comment) would look like:
Suggested change
| <Text as="p" variant="muted"> | |
| { __( | |
| 'Attributes connected to custom fields or other dynamic data.' | |
| ) } | |
| </Text> | |
| { bindings.length && <Text as="p" variant="muted"> | |
| { __( | |
| 'Attributes connected to custom fields or other dynamic data.' | |
| ) } | |
| </Text> } |
Prettier might have some opinions about formatting.
There was a problem hiding this comment.
Interesting. The ToolsPanle mechanism to toggle the visibility of this item assumes a div element is in use:
gutenberg/packages/components/src/tools-panel/styles.ts
Lines 60 to 64 in b867a5f
I'm not sure I like it and it seems a bit fragile to me.
There was a problem hiding this comment.
The fix outlined by @SantosGuillamot in #67427 (comment) would look like:
Prettier might have some opinions about formatting.
I tested it a bit and it could use Object.keys( filteredBindings ).length. However, that would make the help text appear after:
- An attribute is added to the ToolsPanel UI
- And a source value has been set to the binding.
Basically, the help text would appear only after a source has been set. Instead, on trunk it appears immedialy after an attribute is added. As such, I think we need to use the ToolsPanel mechanism, which assumes a div element.
There was a problem hiding this comment.
I would personally argue that the behavior present in trunk isn't entirely valid as you need to explicitly select a binding after exposing the attribute name in the UI, so it might be misleading as of today. Anyway, the proposed fix also works.
|
Last commit restores the automatic visibility toggling behavior of the
|
afercia
changed the title
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
* Remove one occurrence of incorret usage of ItemGroup. * Fix toggling visibility of the help text. Co-authored-by: afercia <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: SantosGuillamot <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Remove one occurrence of incorret usage of ItemGroup. * Fix toggling visibility of the help text. Co-authored-by: afercia <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: SantosGuillamot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #67425
What?
The
<ItemGroup>component should only contain<Item>sub-components as it's intended to render alistwithlistitems. This quick PR removes one incorrect usage.Why?
<ItemGroup>should be used correctly, according to the documentation, only to render a list with listitems, i.e. a semantically and logically grouped set of items.It must not be used only for visual purposes.
How?
Use a paraagraph instead of an
<ItemGroup>.Testing Instructions
contentattribute.Attributes connected to custom fields or other dynamic data.is now rendered within a paragraph element and it's not wrapped within a div withrole=listany longer.Testing Instructions for Keyboard
Screenshots or screencast