Fix: Remove parent block selector while in Write mode #67395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@jorgefilipecosta, #65577 seems something that can be implemented here as well |
|
Size Change: -22 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/Remove-parent-block-selector-while-in-Write-mode
branch
from
fe1fae7 to
15cd4bf
Compare
Hi @Mamaduka, I think this PR also fixes #65577, if a pattern is content-locked now we don't render the parent selector when inside that parent. |
|
@Mamaduka would you be able to review this PR 😊? |
|
@jorgefilipecosta, it's on my list, and I will do a proper review first thing tomorrow morning. |
Mamaduka
reviewed
Dec 4, 2024
Comment on lines
47
to
48
| getBlockEditingMode( selectedBlockClientId ) !== | ||
| 'contentOnly' && |
There was a problem hiding this comment.
I think we should add this condition to the PrivateBlockToolbar component. It already has the same logic, and we're just duplicating it here. That will also void adding the has-parent class to the toolbar and fix its position.
gutenberg/packages/block-editor/src/components/block-toolbar/index.js
Lines 134 to 143 in ce00a5f
Also, we can remove the isVisible logic from this component since the check already happens parent.
Screenshot
There was a problem hiding this comment.
Thank you @Mamaduka good point, your feedback was applied.
jorgefilipecosta
force-pushed
the
fix/Remove-parent-block-selector-while-in-Write-mode
branch
from
15cd4bf to
c79a28d
Compare
jorgefilipecosta
requested review from
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
jorgefilipecosta
force-pushed
the
fix/Remove-parent-block-selector-while-in-Write-mode
branch
from
c79a28d to
d9fbc25
Compare
Mamaduka
reviewed
Dec 5, 2024
Comment on lines
140
to
141
| getBlockEditingMode( selectedBlockClientId ) !== | ||
| 'contentOnly' && |
There was a problem hiding this comment.
Nit (non-blocking): the block editing mode for the selected one is already available here. See the editingMode variable above.
|
Flaky tests detected in d9fbc25. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12184363069
|
Mamaduka
approved these changes
Dec 5, 2024
Mamaduka
deleted the
fix/Remove-parent-block-selector-while-in-Write-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #66684
Fixes: #65577
Removes the parent selector while in write mode.
cc: @richtabor
Testing Instructions
Enable the write mode under experiments.
Change the post to write mode.
Add a pattern e.g: a call to action.
Select a paragraph block and verify the parent selector is not available.