-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Add stories for HeadingLevelDropdown component #67294
Storybook: Add stories for HeadingLevelDropdown component #67294
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth waiting to merge until feedback is shared on #67165 (comment). It may also be worthwhile to request code review from those that respond, I have less context on the state or desires for Storybook usage.
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've made a few suggestions, but overall it seems good 👍
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js
Show resolved
Hide resolved
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js
Outdated
Show resolved
Hide resolved
Hi @t-hamano, Thanks for the feedback! I’ve updated it accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Works as expected 👍
Part of #67165
What?
This PR will add stories for HeadingLevelDropdown component in the Storybook
Testing Instructions
npm run storybook:dev
HeadingLevelDropdown
stories.Screenshots or screencast