Style panel: use correct revisions count #67180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -38 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7855cda. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11943584777
|
afercia
reviewed
Nov 21, 2024
packages/edit-site/src/components/sidebar-navigation-screen-details-footer/index.js
Outdated
Show resolved
Hide resolved
afercia
reviewed
Nov 21, 2024
packages/edit-site/src/components/sidebar-navigation-screen-details-footer/index.js
Outdated
Show resolved
Hide resolved
afercia
reviewed
Nov 21, 2024
packages/edit-site/src/components/sidebar-navigation-screen-global-styles/index.js
Outdated
Show resolved
Hide resolved
afercia
reviewed
Nov 21, 2024
packages/edit-site/src/components/sidebar-navigation-screen-global-styles/index.js
Outdated
Show resolved
Hide resolved
…to the footer component. This allows us to remove the globalstyle record selector.
ramonjd
force-pushed
the
fix/styles-revisions-footer-get-accurate-revisions-count
branch
from
7855cda to
409b9a3
Compare
ramonjd
deleted the
fix/styles-revisions-footer-get-accurate-revisions-count
branch
|
Thanks for the feedback and testing @afercia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove the globalstyle record selector.
What?
For the styles panel
<SidebarNavigationScreenGlobalStyles />component, send the correct recordCount via optional prop to the footer component<SidebarNavigationScreenDetailsFooter />.Props to @afercia for catching it over in #66606 (comment)
Why?
<SidebarNavigationScreenGlobalStyles />was passing a revision record to<SidebarNavigationScreenDetailsFooter />. Revision records do not contain a_linksobject, and therefore the record history count is not accessible.How?
Pass the correct revisionsCount to the component.
Testing Instructions
The record count for global revisions is not actually used in the side panel, so the way to test is it to log out the revisionsCount in
<SidebarNavigationScreenDetailsFooter />.Create a few global styles revisions by editing a theme's global styles and saving.
The open up the left-hand style panel in the site editor.
Check the
revisionsCountin the console.Then click on the "Last modified link" to open revisions in the editor. The number in the revisions pane should match.