Avoid using width: fit-content for images that use auto-sizes #66801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @EldarAgalarov. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +96 B (+0.01%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Good investigation here, @felixarntz. I'd go further and suggest that adding Currently the image block doesn't add dimensions directly to the |
|
@felixarntz Too many avoids for this rule. This inconsistent rule should be removed at all. WP images worked without it for years. |
|
An alternative PR to remove fit-content has been created , see #66804 |
|
#66804 solve the issue and backported from GB. Once it committed we can close these PR. |
|
Thank you, all. |
|
I'll close this since #66804 was merged. |
kevin940726
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #66217 and #66643.
This fixes a bug reported in https://core.trac.wordpress.org/ticket/62345 that leads to incorrect display for images with
sizes="auto". See https://core.trac.wordpress.org/ticket/62345#comment:2 for details.What?
Exclude
width: content-fitfor images that usesizes="auto".Why?
Having
width: content-fiton these images leads to a visual bug on browsers that supportsizes="auto", per the HTML specification https://html.spec.whatwg.org/multipage/rendering.html#img-contain-size.As this surfaces in the new Twenty Twenty-Five theme for instance and appears on heavily used browsers, I believe this is a critical visual bug and therefore needs to be fixed before the 6.7 release.
Testing Instructions
sizes="auto", e.g. Chrome (see https://caniuse.com/mdn-html_elements_img_sizes_auto).core/imageblocks, each width different images.sizes="auto") will be displayed with only 300px width. With this fix, they are displayed correctly.