Upgrade browserslist and webcompat data packages #65926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
force-pushed
the
upgrade/browserslist-et-al
branch
from
07ee680 to
cd0cb21
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jsnajdr
force-pushed
the
upgrade/browserslist-et-al
branch
from
cd0cb21 to
43f5763
Compare
|
The issue exists for the 
We could verify that by limiting what gets build as scripts for the Form block: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/form/view.js Then, we can refactor this block to Interactivity API and finish the cleanup started in #65268. |
|
I pushed the potential fix in 2bc2686 where the view script is only built for the Form block that really needs it. The rest of view scripts were obsolete as they are powered now by view script modules built with another webpack config. Let's see if it resolves the issue. |
Yes, I expected this to be an uneventful update, but no, we are in a rabbit hole again 😃 There must have been some change in the compat data that specify if a given platform supports dynamic |
|
This is how the error arises:
Therefore, if you claim to support the Fortunately, it's webpack who has wrong info about |
jsnajdr
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
Size Change: -4.67 kB (-0.26%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Oct 9, 2024
sirreal
reviewed
Oct 9, 2024
Comment on lines
61
to
63
| const blockViewScriptPaths = fastGlob.sync( | ||
| './packages/block-library/build-module/**/view*.js' | ||
| './packages/block-library/build-module/form/view.js' | ||
| ); |
There was a problem hiding this comment.
@gziolo In a follow-up we can make this a viewScriptModule and remove this single case. It seems to be a single module with no dependencies, an easy migration.
There was a problem hiding this comment.
Yes, it seems straightforward but I went with a quick change here to rule it out as a source of issue.
|
Flaky tests detected in a663fba. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11252130767
|
gziolo
approved these changes
Oct 9, 2024
|
Thanks @sirreal for updating the snapshots! |
|
Thank you for taking care of this, @jsnajdr! 👍 |
6 tasks
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Upgrade browserslist and webcompat data packages * Limit view scripts to the Form block * Update blocks.js * Upgrade also webpack * Update snapshots --------- Co-authored-by: jsnajdr <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: sirreal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by a recent discussions with @sgomes about polyfills, here is a PR that upgrades the relevant packages (used to determine which polyfills to use and to build them) to their latest versions.
How to test: I don't think anything really changes, except that we have slightly newer data about browser/feature compat.