Update "hidden" icon to be clearer, and invert logic as used in Data Views #65914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -79 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Oct 7, 2024
There was a problem hiding this comment.
I'd be happy for others to give feedback on the icon itself, but I think inverting the icon and changing it to a strikethrough eye makes sense.
It also matches the icon on the login screen:
This PR also brings Storybook's password field into consistency with the login screen:
http://localhost:50240/?path=/story/components-experimental-inputcontrol--show-password
jameskoster
approved these changes
Oct 7, 2024
|
Thank you. Do I need to add a changelog entry? |
|
The icon design has changed so much that it might be worth adding a changelog. |
|
It might be worth adding a data views changelog entry too? |
|
Done, but 😩—the tests fail so often these days, I have to restart them endlessly. |
|
It seems that many other PRs have failed tests as well, so let's try restarting it at a later date 👍 |
|
The tests should pass now. See #65939 |
|
Thanks for all the help! |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…Views (WordPress#65914) Co-authored-by: jasmussen <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: jameskoster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the
unseenicon to be clearer, and inverts the logic for which icon to show in Data View configurations.For the moment, the eye is a closed eye, and the seen icon is shown for the button that hides a particular property:
In this branch, I'm proposing an alternatetive to the closed icon, an eye with a strike-through. This is similar to icons for unlink, remove-submenu, remove-bug, and other similar icon pairs. Additionally it shows the unseen icon for the action to hide a particular property:
Testing Instructions
Please test the site editor > Pages, and test the "View options" dropdown.