Use correct label in PHP Backport documentation #65908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kevin940726
approved these changes
Oct 7, 2024
| @@ -31,7 +31,7 @@ There are however certain exceptions to that rule. PRs with the following criter | |||
|
|
|||
| - Does not contain changes to PHP code. | |||
| - Has label `Backport from WordPress Core` - this code is already in WP Core and is being synchronized back to Gutenberg. | |||
| - Has label `Backport to WordPress Core` - this code has already been synchronized to WP Core. | |||
| - Has label `Backported to WordPress Core` - this code has already been synchronized to WP Core. | |||
There was a problem hiding this comment.
Should we also change this to
Suggested change
| - Has label `Backported to WordPress Core` - this code has already been synchronized to WP Core. | |
| - Has label `Backported to WP Core` - this code has already been synchronized to WP Core. |
to match the actual label name?
getdave
force-pushed
the
fix/label-typo-in-php-backport-docs
branch
from
0cd6375 to
8dce5ce
Compare
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: getdave <[email protected]> Co-authored-by: kevin940726 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Uses correct label in the PHP Backporting documentation
Why?
Because details matter...
How?
Corrects label from
Backport to WP CoretoBackported to WP Core(past tense).Testing Instructions
Read words.
Testing Instructions for Keyboard
Screenshots or screencast