Re-enable zoom out e2e tests #63379
Closed
Re-enable zoom out e2e tests #63379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
[Type] Code Quality
|
Passing for me locally, seeing if it passes on here or if it's still flaky. |
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
|
@jeryj, as I mentioned in the issue description, I think the test itself needs to be more explicit about what it is testing. |
|
@MaggieCabrera @scruffian - Do you recall what is being tested and how this test works? It's not super clear what's going on with it. |
|
it might not be very useful at this point in time to keep this test (in that case we could just delete it). The idea is that triggering zoom out mode opens the inserter with the pattern tab focused, that's mainly what we were trying to test here. |
|
Closing in favor of #65943 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #63330
Why?
See if it's no longer flaky since a zoom out bug was fixed in #63315
How?
Testing Instructions
npm run test:e2e:playwright test/e2e/specs/site-editor/zoom-out.spec.jsTesting Instructions for Keyboard
Screenshots or screencast