Fix site editor breaking when user selects bound and non-bound blocks at the same time #62268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
requested review from
gziolo,
artemiomorales,
kevin940726 and
cbravobernal
SantosGuillamot
added
[Type] Bug
SantosGuillamot
changed the title
SantosGuillamot
changed the title
29 tasks
|
Size Change: +1 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix a bug that breaks the site editor when user select blocks that use bindings and blocks that don't.
If I am not mistaken, it was introduced in this pull request, so I might be missing context.
Why?
It breaks the editor.
How?
At this point, ensure that if there are no bindings it iterates through an empty object.
Testing Instructions
Screenshots or screencast
Before
Not.working.mp4
After
Working.mp4