Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullquote Block #607

Merged
merged 10 commits into from
May 5, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions blocks/library/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ import './list';
import './quote';
import './separator';
import './button';
import './pullquote';
70 changes: 70 additions & 0 deletions blocks/library/pullquote/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
/**
* Internal dependencies
*/
import './style.scss';
import { registerBlock, query as hpq } from 'api';
import Editable from 'components/editable';

const { children, query } = hpq;

registerBlock( 'core/pullquote', {
title: wp.i18n.__( 'Pullquote' ),
icon: 'format-quote',
category: 'common',

attributes: {
value: query( 'blockquote > p', children() ),
citation: children( 'footer' ),
},

edit( { attributes, setAttributes, focus, setFocus } ) {
const { value, citation } = attributes;

return (
<blockquote className="blocks-pullquote">
<Editable
value={ value || wp.i18n.__( 'Write Quote…' ) }
onChange={
( nextValue ) => setAttributes( {
value: nextValue
} )
}
focus={ focus && focus.editable === 'value' ? focus : null }
onFocus={ () => setFocus( { editable: 'value' } ) }
/>
{ ( citation || !! focus ) && (
<footer>
<Editable
tagName="footer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With tagName you no longer need the <footer> wrapper. Currently this will render as <footer><footer></footer></footer>.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, fixed in #687

value={ citation || wp.i18n.__( 'Write caption…' ) }
onChange={
( nextCitation ) => setAttributes( {
citation: nextCitation
} )
}
focus={ focus && focus.editable === 'citation' ? focus : null }
onFocus={ () => setFocus( { editable: 'citation' } ) }
inline
/>
</footer>
) }
</blockquote>
);
},

save( { attributes } ) {
const { value, citation } = attributes;

return (
<blockquote className="blocks-pullquote">
{ value && value.map( ( paragraph, i ) => (
<p key={ i }>{ paragraph }</p>
) ) }

{ citation && citation.length > 0 && (
<footer>{ citation }</footer>
) }
</blockquote>
);
}
} );
23 changes: 23 additions & 0 deletions blocks/library/pullquote/style.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
.blocks-pullquote {
color: $light-gray-900;
padding: 2em;
text-align: center;

footer {
color: $dark-gray-900;
position: relative;
}

footer p {
font-size: 16px;
font-family: $default-font;
}
}

.editor-visual-editor .blocks-pullquote {
& > .blocks-editable p {
font-family: $default-font;
font-size: 48px;
font-weight: 900;
}
}