-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeMirror to Additional CSS / Custom HTML block #60155
Open
okmttdhr
wants to merge
23
commits into
trunk
Choose a base branch
from
add/codemirror
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f23e475
Add codemirror to Additional CSS
okmttdhr 7b38263
Add codemirror to Custom HTML block
okmttdhr b2ceddd
Fix styles
okmttdhr 14678ea
Add focus change effect
okmttdhr 421f2d4
Add codemirror as restrictedImport
okmttdhr 4decdff
Ensure minimum lines to be full-width
okmttdhr a3e89a9
Add indenting with tab
okmttdhr 9394fc9
Add instructions to focus out of the editor
okmttdhr 15e2486
Align styles with the existing ones
okmttdhr 59a81b5
Fix lint
okmttdhr 4c6262c
Extract EditorView component
okmttdhr ee88fcd
Fix incorrect use of var()
okmttdhr a6519f2
Reuse EditorView component
okmttdhr 57f4770
Fix wrong package version
okmttdhr dff73f6
Fix typo in variable name
okmttdhr e7aa264
Remove unnecessary condition in useEffect
okmttdhr fb5ba29
Use @\mixins
okmttdhr a106416
Add VisuallyHidden component to hide editor instructions
okmttdhr 30ae96e
Fix editor height isn't calculated properly
okmttdhr af8af11
Use BaseControl for Additional CSS
okmttdhr b0054fc
Utilize useInstanceId
okmttdhr ab79885
Switch the editor's light/dark mode
okmttdhr 6a4b77d
Merge branch 'trunk' into add/codemirror
okmttdhr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit repetitive. Does it make sense to use the
patterns
option to combine them into a single restricted import?