Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make command palette string transatables #59133

Merged
merged 4 commits into from
Feb 17, 2024
Merged

Make command palette string transatables #59133

merged 4 commits into from
Feb 17, 2024

Conversation

MarieComet
Copy link
Contributor

See the related issue : #59132

@MarieComet MarieComet mentioned this pull request Feb 16, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: MarieComet <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: huzaifaalmesbah <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@huzaifaalmesbah
Copy link
Contributor

I See Your PR Looks Good. Thanks for PR

t-hamano
t-hamano reviewed Feb 17, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

I believe these changes are correct, but it seems to be failing the lint check because it's indented with spaces instead of tabs. If you commit the suggestions below, it should be resolved.

At the same time, I also fixed the placeholder format (%1$s), which was originally incorrect.

packages/edit-site/src/hooks/commands/use-edit-mode-commands.js Outdated Show resolved Hide resolved
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js Outdated Show resolved Hide resolved
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js Outdated Show resolved Hide resolved
packages/edit-site/src/hooks/commands/use-edit-mode-commands.js Outdated Show resolved Hide resolved
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Edit Site /packages/edit-site labels Feb 17, 2024
@t-hamano t-hamano linked an issue Feb 17, 2024 that may be closed by this pull request
Not all command palette strings are translatable. #59132
Closed
@MarieComet
Copy link
Contributor Author

Hi @t-hamano
Thanks for the review.
I commited your suggestions and fixed another incorrect placeholder format in comment.

@t-hamano t-hamano self-requested a review February 17, 2024 14:36
t-hamano
t-hamano approved these changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! GitHub Actions is all ✅. Thanks for your great work!

@t-hamano t-hamano merged commit 98e6dab into WordPress:trunk Feb 17, 2024
57 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 17, 2024
@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 20, 2024
getdave pushed a commit that referenced this pull request Feb 20, 2024
@MarieComet @t-hamano
@huzaifaalmesbah @getdave
Make command palette string transatables (#59133)
e14c1d9 
* Make command palette string transatables

* Apply suggestions from code review

Co-authored-by: Aki Hamano <[email protected]>

* Fix %1$s in command palette comment translation

* fix lint JS in use-edit-mode-command.js

---------

Co-authored-by: MarieComet <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: huzaifaalmesbah <[email protected]>
@getdave
Copy link
Contributor

getdave commented Feb 20, 2024

I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: e14c1d9

@getdave getdave removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 20, 2024
@getdave getdave mentioned this pull request Feb 20, 2024
Merged
youknowriad pushed a commit that referenced this pull request Feb 20, 2024
@MarieComet @t-hamano
@huzaifaalmesbah @youknowriad
Make command palette string transatables (#59133)
b2c5f41 
* Make command palette string transatables

* Apply suggestions from code review

Co-authored-by: Aki Hamano <[email protected]>

* Fix %1$s in command palette comment translation

* fix lint JS in use-edit-mode-command.js

---------

Co-authored-by: MarieComet <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: huzaifaalmesbah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 17.8
Development

Successfully merging this pull request may close these issues.

Not all command palette strings are translatable.
5 participants
@MarieComet @huzaifaalmesbah @getdave @t-hamano @youknowriad