Rich Text: Add aria-readonly attribute to Rich Text component #58687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemiomorales
changed the title
|
Size Change: -730 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
artemiomorales
added
[Feature] Rich Text
artemiomorales
requested review from
ellatrix,
fluiddot and
dcalhoun
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
approved these changes
Feb 7, 2024
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
To improve accessibility on Block Bindings elements that use Rich Text components with the
contenteditableattribute, this PR adds thearia-readonlyattribute to them.Why?
This follows an accessibility recommendation mentioned here and can help ensure that elements with bound content attributes via the Block Bindings API, namely paragraphs, headings, and buttons, are marked up correctly as the ability to edit them toggles on and off.
Please note that this PR is simply meant to address low-hanging fruit regarding the markup and does not address the screen reader behavior outlined in the issue above.
How?
It adds the
aria-readonlyattribute to theRichTextcomponent.In addition, it adds a check that was missing to ensure that we only add the attribute to blocks that support bindings.
Testing Instructions
Blocks that Support Bindings
functions.phparia-readonlyattribute has been added with a value oftrueAdditionally, test steps 2-4 for the heading and button blocks using the following markup:
Heading
Button
Blocks that Don't Support Bindings
I'll just illustrate one block that uses Rich Text and doesn't support bindings here, namely the list block, but you could test others:
aria-readonlyattribute has a value offalse