Query Loop: Fix posts list variation detection #58194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: -84 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 36307d8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7641722830
|
jsnajdr
reviewed
Jan 24, 2024
| @@ -53,6 +54,9 @@ const variations = [ | |||
| }, | |||
| }, | |||
| scope: [ 'inserter' ], | |||
| isActive: ( { namespace, query } ) => { | |||
| return namespace === 'core/posts-list' && query.postType === 'post'; | |||
| }, | |||
| }, | |||
| { | |||
| name: 'title-date', | |||
There was a problem hiding this comment.
The other variations like Title & Date or Title & Excerpt, would they benefit from isActive, too?
There was a problem hiding this comment.
No, because they use the scope: [ 'block' ], which is used for the placeholder and they essentially are there to add some starting inner blocks.
jsnajdr
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #58168
Core Query Loop's variation
posts listwas missing a proper way of being detected if is active(by not using theisActiveAPI). The reason for that is that the aforementioned API was introduced later.This PR uses the proper APIs for variations and additionally removes the
__experimentalGetMatchingVariation(that you could say it evolved into thegetActiveBlockVariation).Testing Instructions
Posts Listblock(the variation) and observe that as long as you also preserve the queried postType to bepost, the proper title is shown in all places(list view, block card, breadcrumbs, etc..)Bonus testing
blockTypes: ['core/query/posts-list'] and when you insert the block in the editor clickChoose`. Your pattern should be suggested.