(editor)(fix) Append the edit-post-header-toolbar class in NavigableToolbar for backward compatibility with plugin GUI injections
#58154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r` as some plugins use it to append GUIs to it
|
Size Change: -7.06 kB (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
fullofcaffeine
added
the
[Type] Bug
fullofcaffeine
changed the title
edit-post-header-toolbarclass in NavigableToolbar for backward compatibility with plugin GUI injectionsedit-post-header-toolbar class in NavigableToolbar for backward compatibility with plugin GUI injections
youknowriad
approved these changes
Jan 24, 2024
Sure 👍🏻 |
|
The linked |
Done in f8a2780. |
fullofcaffeine
deleted the
keep/css-classes-in-the-edit-post-header-for-plugins-backward-compatibility
branch
fullofcaffeine
added a commit
that referenced
this pull request
Jan 24, 2024
…eToolbar for backward compatibility with plugin GUI injections (#58154) * Keep the `edit-post-header-toolbar` CSS class in the `NavigableToolbar` as some plugins use it to append GUIs to it * Add comment justifying the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Before Gutenberg 17.5, the
edit-post-header-toolbarCSS class was hardcoded inNavigableToolbarsclassName, see #. This changeset then change the hardoded string to the following call:{ classnames( 'editor-document-tools', className) }while not keeping the old class in the list.Why?
3rd party plugins might use that classname to select the element and inject GUIs there, like buttons. An example of that is Elementor. It uses the
edit-post-header-toolbarCSS class to find the div it will append the#elementor-gutenberg-button-switch-modebutton to (see the line here). That div was hardcoded before the changes in #57214, but now uses the following expression:{ classnames( 'editor-document-tools', className ) }to render its classname (see the diff here), which results incomponents-accessible-toolbar editor-document-tools is-unstyledin the markup. TL;DR: Elementor can't find the elementHow?
By adding the
edit-post-header-toolbaras one of the params of theclassnamesfunction call so that it will be rendered alongside them.Testing Instructions
Edit with elementorbutton in the toolbar;trunk, reload the editor;