Patterns: avoid fetching on load #57929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +121 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/avoid-patterns-fetching-on-load
branch
from
cf9334c to
ab29d7d
Compare
|
Flaky tests detected in 708ff92. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7582172787
|
ellatrix
force-pushed
the
try/avoid-patterns-fetching-on-load
branch
from
ce3e9b9 to
85a935c
Compare
ellatrix
changed the base branch from
trunk
to
try/registry-selectors-switching-registries
ellatrix
force-pushed
the
try/avoid-patterns-fetching-on-load
branch
from
85a935c to
3b24b49
Compare
ellatrix
force-pushed
the
try/registry-selectors-switching-registries
branch
from
2a77bb2 to
73cccd9
Compare
ellatrix
force-pushed
the
try/avoid-patterns-fetching-on-load
branch
from
3b24b49 to
2df8042
Compare
ellatrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Currently all patterns are fetched from the server at editor setup, to be passed to the block editor as a setting. This is not ideal because the editor doesn't require the list of patterns until you open the inserter.
This PR adds a new setting that is an async function to get the patterns. This function can then be used in a resolver in the blocks-editor store, allowing us to fetch the patterns only when needed.
How?
One interesting implementation detail is that resolvers cannot be called from plain state selectors. They must be called within a registry selector. The current patterns selectors are memoized selectors. Thanks to #57888 and #57943 this works now!
Testing Instructions
Open the inserter's patterns tab. All e2e tests should pass.
Testing Instructions for Keyboard
Screenshots or screencast