Editor: Unify the DocumentTools component #57214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
force-pushed
the
unify/document-tools
branch
from
997621b to
e68595f
Compare
|
Size Change: -21.1 kB (-1%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Dec 20, 2023
| getBlockRootClientId, | ||
| getBlockSelectionEnd, | ||
| getSettings, | ||
| } = select( blockEditorStore ); |
There was a problem hiding this comment.
Aren't settings also available in the store of the package? I guess we anyway add a subscription to the block editor store so it's fine
youknowriad
force-pushed
the
unify/document-tools
branch
from
e68595f to
7e63f30
Compare
youknowriad
force-pushed
the
unify/document-tools
branch
from
1cddb68 to
c663917
Compare
|
Flaky tests detected in 3d79772. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7286680102
|
youknowriad
force-pushed
the
unify/document-tools
branch
from
d9252ce to
3d79772
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This PR continues the work on the great unification between post and site editors. This PR unifies the DocumentTools (left part of the editor header toolbar) component between edit site and edit post.
Testing instructions