Editor: Unify the preview dropdown between post and site editors #56921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
commented
Dec 9, 2023
youknowriad
force-pushed
the
update/preview-dropdown
branch
from
5ec4a35 to
8e52e2d
Compare
|
Size Change: -440 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 67b8625. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7166720819
|
t-hamano
reviewed
Dec 10, 2023
t-hamano
reviewed
Dec 10, 2023
There was a problem hiding this comment.
Overall, looks good to me! There are only two points of concern.
In the Post Editor, I noticed that the button tooltip has changed from "Preview" to "View". However, this does match the context of the dropdown menu's aria label, so I consider it an improvement.
There are no longer disabled button in template parts and patterns. In the past, we intentionally left this disabled button. Here is the background: #53913 (comment)
|
@t-hamano Both of these were intended in this PR. Basically, each time I find a problem, I try to lean on the "simple" approach first.
|
|
Ok, I've restored the disabled state. |
t-hamano
approved these changes
Dec 11, 2023
anomiex
added a commit
to Automattic/wp-calypso
that referenced
this pull request
Jan 5, 2024
* WordPress/gutenberg#56921 changed the label of the preview button from "Preview" to "View". * WordPress/gutenberg#56904 removed the setting of an `is-xxx-preview` class when using the in-page preview. Targeting the parent element (that has a static class) instead. * #86033 attempted to fix a test for another Gutenberg change, but the selector used there matches multiple elements in one of our tests and so causes it to fail. Adding `[role="tab"]` into the selector fixes that.
7 tasks
sdixon194
pushed a commit
to Automattic/wp-calypso
that referenced
this pull request
Jan 5, 2024
* WordPress/gutenberg#56921 changed the label of the preview button from "Preview" to "View". * WordPress/gutenberg#56904 removed the setting of an `is-xxx-preview` class when using the in-page preview. Targeting the parent element (that has a static class) instead. * #86033 attempted to fix a test for another Gutenberg change, but the selector used there matches multiple elements in one of our tests and so causes it to fail. Adding `[role="tab"]` into the selector fixes that.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This PR continues the work on the great unification between post and site editors. This PR unifies the DevicePreview or PreviewDropdown component. It also brings some consistency meaning that now:
Testing instructions