Block editor: hooks: share block settings #56852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Dec 7, 2023
| @@ -137,8 +133,7 @@ function BordersInspectorControl( { children, resetAllFilter } ) { | |||
| ); | |||
| } | |||
|
|
|||
| function BorderPanelPure( { clientId, name, setAttributes } ) { | |||
| const settings = useBlockSettings( name ); | |||
There was a problem hiding this comment.
Not sure if __unstableParentLayout was forgotten here or intentionally omitted.
|
Size Change: -4 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e25a6ec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7126857853
|
youknowriad
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of a larger effort to reduce store subscriptions per block (#56847), let's reuse the block settings subscription for all the style hooks.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast