DataViews: update sorting semantics #56717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
youknowriad,
andrewhayward,
jameskoster,
ciampo,
jorgefilipecosta and
ntsekouras
oandregal
added
[Type] Experimental
|
Size Change: -24 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
This part is working 👍 I am noticing some strange behavior though, potentially unrelated to this PR, but figured I'd note them down. sorting.mp4
|
|
Tried with in pages and templates, but I cannot reproduce (tested with and without pagination) 🤔 Gravacao.do.ecra.2023-12-01.as.16.49.32.movGravacao.do.ecra.2023-12-01.as.16.48.36.mov |
I don't see why this is bad? Sometimes it will be visible how the items are sorted by default and sometimes not, but in the end if we sort by one field, I don't see the reason why a user cannot reset to the default sorting that was used. |
For me, it's about whether "unsorting" is a use case we need to support and what's the complexity that comes with it. It's not good or bad, but a trade-off. I am concerned that supporting "unsorting" forces us to stretch the semantics of the UI components (radios cannot have an "unset" status after they are set). See #55625 (comment) and #55625 Of course, if there were use cases, we just find engineering solutions for it. My point is that I don't see any use case, hence why I argue we should make it work like the pagination or layout options, for example. Do you feel strongly about maintain this behavior? Is there a use case you have in mind? |
oandregal
force-pushed
the
update/sorting-semantics
branch
from
d1cb3fc to
8d4b010
Compare
Not really, but I think it's something we could decide later on and leave as is for now. I'm fine if others also think we should remove. |
|
In case we wanted to preserve the behavior, we could add an extra radio option called |
oandregal
force-pushed
the
update/sorting-semantics
branch
from
8d4b010 to
18f483d
Compare
The current sorting behavior is blocking #55625 Unless we come up with any other suggestion, our options forward are 1) making it work like a radio (this PR) or 2) add a none option (which design seems to be against, and it's different from how the other things work). To prevent 55625 from being blocked, I'd rather do 1 and revisit if necessary. cc @ciampo or @andrewhayward is the above summary fair? are you perhaps available to approve this approach so we unblock 55625? |
|
Flaky tests detected in 18f483d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7165419457
|
|
My instinct is that it's fine to proceed with this PR. Unsorting doesn't really make sense as there will always be a sort order, even if it's the default one (which should be represented in the UI accordingly). If toggling off sort order for one field also toggles sorting on for another I think that might feel a bit unexpected. Imo it's more natural to choose a new sort order than to disable the current one. If a need for a "Reset to default sorting" arises we can explore a design for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
This PR updates the sorting semantics so that once the dataset is sorted, it cannot be "unsorted":
Gravacao.do.ecra.2023-12-01.as.15.42.54.mov
Why?
What does it mean to "unsort" something that's already sorted? It means that it's up to the dataset source (pages endpoint, templates endpoint, etc.) to provide the data in whatever default sorting it provides – the dataset is sorted, we just don't know how.
By aligning sorting semantics with the other view configs that have a single option (pagination or layouts), its UI representation also becomes clear (see refactoring to new components and discussion about checkboxes/radios).
How?
Update
ViewActionsandViewTableso that sorting cannot be unset, once it is set.Testing Instructions