Update: Refactor useAddedBy to use authorText and originalSource fields. #56568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
jorgefilipecosta
force-pushed
the
update/refactor-useAddedBy
branch
from
344873e to
a94c818
Compare
|
Size Change: -96 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Nov 28, 2023
| ].includes( template.source ) ) ) | ||
| ) { | ||
| switch ( originalSource ) { | ||
| case 'theme': { | ||
| return { | ||
| type: 'theme', |
There was a problem hiding this comment.
Nit: we could use the originalSource in the return objects in type prop.
jorgefilipecosta
force-pushed
the
update/refactor-useAddedBy
branch
2 times, most recently
from
2c01a8b to
fd6cfa3
Compare
jorgefilipecosta
force-pushed
the
update/refactor-useAddedBy
branch
from
fd6cfa3 to
f71971b
Compare
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor useAddedBy to use authorText and originalSource fields from the REST API, simplifying the logic of the hook.