DataViews: make items per page an even number #55906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
|
Size Change: +536 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2d09d90. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6774069825
|
|
I'd love more thoughts but personally I'd remove 5 or 6, I'd make 20 the default and maybe add 100 |
|
I also think eventually we'll need to have a bigger number like 20. I started with 5 just for easier testing of pagination when we implement features. |
Implemented this. I am not really opinionated about which numbers to show, as long as they work well with all the layouts we have (5 is not). Note that I initially suggested a number below 10 or 20 because they introduce scrolling. I asked about that at #55905 because it is a bit weird (pagination controls not in the viewport, filters not visible if scrolling down, etc.). |
youknowriad
approved these changes
Nov 7, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Having 5 items as the minimum items per page doesn't work well with the grid view.
In a scenario with more than 5 items we end up with the following (note how the 6th space in the grid is empty, inducing to believe there is no more records, yet the pagination says otherwise):
Why?
To bring clarity to the grid view.
How?
By setting the minimum to 20, see conversation #55906 (comment)
By setting the minimum to 6. I've also tested with 10 as minimum, but that forces scrolling, which has its own issues #55905 I'm not really opinionated on the specific number, though.