Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text and design of the block removal warnings #54715

Closed
wants to merge 10 commits into from
Closed

Improve text and design of the block removal warnings #54715

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
efbbdb0
Improve text and design of the block removal warning modals (#52392)
foosantos Sep 22, 2023
4623c86
Merge branch 'WordPress:trunk' into issue-52392
foosantos Oct 11, 2023
7b24111
Update packages/block-editor/src/components/block-removal-warning-mod…
scruffian Dec 6, 2023
00573bf
Update packages/block-editor/src/components/block-removal-warning-mod…
scruffian Dec 6, 2023
e980a3e
Update packages/block-editor/src/components/block-removal-warning-mod…
scruffian Dec 6, 2023
3a463f5
Update packages/block-editor/src/components/block-removal-warning-mod…
scruffian Dec 7, 2023
694bc10
Update packages/block-editor/src/components/block-removal-warning-mod…
scruffian Dec 7, 2023
4e3f4b1
Update packages/block-editor/src/components/block-removal-warning-mod…
scruffian Dec 7, 2023
19c00ed
Update packages/block-editor/src/components/block-removal-warning-mod…
scruffian Dec 7, 2023
a070b92
Update packages/block-editor/src/components/block-removal-warning-mod…
scruffian Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions packages/block-editor/src/components/block-removal-warning-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,30 @@ export function BlockRemovalWarningModal( { rules } ) {
onRequestClose={ clearBlockRemovalPrompt }
>
{ blockNamesForPrompt.length === 1 ? (
<p>{ rules[ blockNamesForPrompt[ 0 ] ] }</p>
<p>
{ rules[ blockNamesForPrompt[ 0 ] ] }{ ' ' }
scruffian marked this conversation as resolved.
Show resolved Hide resolved
{ __(
"Only proceed to remove this block if you're absolutely sure of what you're doing."
scruffian marked this conversation as resolved.
Show resolved Hide resolved
) }{ ' ' }
scruffian marked this conversation as resolved.
Show resolved Hide resolved
</p>
) : (
<ul style={ { listStyleType: 'disc', paddingLeft: '1rem' } }>
{ blockNamesForPrompt.map( ( name ) => (
<li key={ name }>{ rules[ name ] }</li>
) ) }
</ul>
<>
<ul
style={ { listStyleType: 'disc', paddingLeft: '1rem' } }
>
{ blockNamesForPrompt.map( ( name ) => (
<li key={ name }>{ rules[ name ] }</li>
) ) }
</ul>
scruffian marked this conversation as resolved.
Show resolved Hide resolved
<p>
{ ' ' }
{ __(
"Only proceed to remove these blocks if you're absolutely sure of what you're doing."
scruffian marked this conversation as resolved.
Show resolved Hide resolved
) }
</p>
</>
) }
<p>
{ blockNamesForPrompt.length > 1
? __( 'Removing these blocks is not advised.' )
: __( 'Removing this block is not advised.' ) }
</p>

<HStack justify="right">
<Button variant="tertiary" onClick={ clearBlockRemovalPrompt }>
{ __( 'Cancel' ) }
Expand Down
Loading